Revert "gptel-rewrite: Diff buffers, not files (#731)" #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ce917a. The above commit while not wrong per se, prevents to use diff-mode to apply hunks, which makes it not a good tradeoff.
Owner
|
If possible, I would rather find a way to get diff-mode to apply the hunks to buffers. I'll look into it, but if you've studied this already you can let me know if this is possible. |
Contributor
Author
|
That I would prefer too indeed. It didn't appear possible, but I didn't spend much time trying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0ce917a.
The above commit while not wrong per se, prevents to use diff-mode to apply hunks, which makes it not a good tradeoff.